CSLA 4.1 BusinessRule - AffectedProperty not Dirty according to FieldManager

Jaans posted on Thu, Jul 7 2011 2:36 AM

rated by 0 users

Hi all

Unless my expectation of what should happen is wrong, I have a potential bug.

I have a business rule that is a mutator (i.e. changes the value of properties), specifically I have the rule trigger on the primary property called PropertyA. In the rule I let CSLA know that there will be an affected property (called PropertyB), and then in the rule execution I set the value of the property using context.AddOutValue(...).

The problem is that after the rule is triggered and therefore executes, that the FieldManager.IsFieldDirty( PropertyB ) remains false, despite the property change that came from the rule's context.AddOutValue( ... ),

Below is an example of the rule (sorry if it seems contrived, but only because I'm taking out unrelated "fluff"):

        private class PropertyAChangeMutatesPropertyB : BusinessRule
        {
            public PropertyAChangeMutatesPropertyB() : base( PropertyAProperty )
            {
                AffectedProperties.Add( PropertyBProperty );
            }
 
            protected override void Execute( RuleContext context )
            {
                var target = (MyBusinessObject)context.Target;
 
                // If PropertyA is dirty, then we need to set a default for PropertyB
                if ( target.FieldManager.IsFieldDirty( PropertyAProperty ) )
                {
                    // Default value for property
                    context.AddOutValue( PropertyBProperty, DateTime.Now );
                }
            }
        }

And here's the code that doesn't behave as expected:

            var myBusinessObject = MyBusinessObject.Get();
            myBusinessObject.PropertyA = new DateTime( 2000, 12, 31 ); // Trigger the Rule
 
            // The Rule does execute
            // ...
 
            // Wrong result
            var shouldBeDirtyButIsNot = myBusinessObject.FieldManager.IsFieldDirty( PropertyBProperty );

Am I wrong to expect that the "AffectedProperty" that is changed by context.AddOutValue( PropertyB, ... ) should be setting the IsDirty state for the field?

Thanks and happy CSLA coding!

Jaans