CSLA .NET discussion

Re: Rule FriendlyName property

Tiago Freitas Leal — Tue, 22 May 2012 21:33:14 GMT

Hi Rocky,

I can see you posted the changes. I'm posting the updated code for CslaActionExtender and CslaActionExtenderTsb right away.

Regards,

Re: Rule FriendlyName property

RockfordLhotka — Tue, 22 May 2012 18:51:10 GMT

Actually I have decided on a different solution to the GetRegisteredProperties issue.

If you think about it, CSLA has its own "type system" using registered properties. This type system is managed by the PropertyInfoManager type in Csla.Core.FieldManager.

That type is current internal, but could be public, with only one public member: GetRegisteredProperties.

    /// <summary>
    /// Returns a copy of the property list for
    /// a given business object type. Returns
    /// null if there are no properties registered
    /// for the type.
    /// </summary>
    /// <param name="objectType">
    /// The business object type.
    /// </param>
    /// <remarks>
    /// Registered property information is only available after at least one instannce
    /// of the object type has been created within the current AppDomain.
    /// </remarks>
    public static PropertyInfoList GetRegisteredProperties(Type objectType)

This change will make the type information available to any code in the application, and without the need for an instance of the business object (though at least one instance must have been created prior to invoking this method).

I like this approach because it avoids cluttering the BusinessBase API, and more closely follows the model of the .NET type system.

Re: Rule FriendlyName property

Tiago Freitas Leal — Tue, 22 May 2012 07:05:42 GMT

Hi again,

Google is my friend and searching for your text pointed me to the VS2005 page.

http://msdn.microsoft.com/en-us/library/87d83y5b(v=vs.80).aspx

Nevertheless, a few paragraphs below the same page states:

Remarks

An interface can be a member of a namespace or a class and can contain signatures of the following members:

Re: Rule FriendlyName property

Tiago Freitas Leal — Tue, 22 May 2012 06:53:57 GMT

Hi Jonny,

Something weird is hapening as my browser shows me a totally different text

An interface contains only the signatures of methods, properties, events or indexers. A class or struct that implements the interface must implement the members of the interface that are specified in the interface definition.

Regards

Re: Rule FriendlyName property

JonnyBee — Tue, 22 May 2012 03:32:02 GMT

Hi Tiago,

You cannot have properties in an interface - only methods, delegates and events.

From MSDN:http://msdn.microsoft.com/en-us/library/87d83y5b%28v=vs.100%29.aspx

An interface contains only the signatures of methods, delegates or events. The implementation of the methods is done in the class that implements the interface, as shown in the following example:

So the purpose is to create a method in an interface (in CSLA or your own Interface as previous in the discussion) that can be mocked easily.

Re: Rule FriendlyName property

RockfordLhotka — Tue, 22 May 2012 02:42:41 GMT

I haven't figured out which interface should get that method yet.

Re: Rule FriendlyName property

Tiago Freitas Leal — Mon, 21 May 2012 23:43:11 GMT

Does it conflicts with the changing of GetManagedProperties() method visibility?

Re: Rule FriendlyName property

Tiago Freitas Leal — Mon, 21 May 2012 23:40:21 GMT

Hi Jonny,

Got the changes.Besides adding a method GetBrokenRules() to ICheckRules I really fail to see the point of this change. This method duplicates the public virtual BrokenRulesCollection property (the difference is that you can't be override it).

As it is, I'm not any closer to get the property FriendlyName. I hope the "consolidated public IBusinessBase interface" Rocky mentions some messages back will help in that particular.

Regards,

Re: Rule FriendlyName property

JonnyBee — Mon, 21 May 2012 18:44:02 GMT

Checked in for both CSLA 4.3 and 4.5

http://www.lhotka.net/cslabugs/edit_bug.aspx?id=1052

Re: Rule FriendlyName property

JonnyBee — Mon, 21 May 2012 17:02:29 GMT

Good, I'll do it in a short time.

Re: Rule FriendlyName property

RockfordLhotka — Mon, 21 May 2012 16:31:28 GMT

The method is currently a public virtual method, and that shouldn't change. I don't want to create a breaking change out of this, just add the method to the ICheckRules interface.

Re: Rule FriendlyName property

RockfordLhotka — Mon, 21 May 2012 15:55:35 GMT

No, we actually want to return the real list. It is designed for this purpose, and so is read-only for external consumers.

The reason for exposing the real list, is that it is a bindable list, so a UI developer can bind it to a control on the screen so the user sees the list of broken rules as they occur.

Re: Rule FriendlyName property

JonnyBee — Mon, 21 May 2012 15:33:45 GMT

Should CSLA.Core.BusinessBase.cs expose the method as

    public BrokenRulesCollection GetBrokenRules()
    {
      return BrokenRulesCollection;
    }

or only through interface

    BrokenRulesCollection ICheckRules.GetBrokenRules()
    {
      return BrokenRulesCollection;
    }

or just return an IEnumerable

    IEnumerable<BrokenRule> ICheckRules.GetBrokenRules()
    {
      return Enumerable.ToArray(BrokenRulesCollection);
    }

Re: Rule FriendlyName property

RockfordLhotka — Mon, 21 May 2012 14:21:56 GMT

Yes, that is what I was thinking.

Re: Rule FriendlyName property

JonnyBee — Mon, 21 May 2012 05:45:15 GMT

BusinessBase has BrokenRulesCollection as a virtual property and Interface does not accept properties.

But we could add a new method to ICheckRules as GetBrokenRules() and return that property.

    /// <summary>
    /// Gets the broken rules for this object
    /// </summary>
    BrokenRulesCollection ICheckRules.GetBrokenRules()
    {
      return BrokenRulesCollection;
    }