CSLA .NET

From Rockford Lhotka's Expert C# 2005 and VB 2005 Business Objects books

Welcome to CSLA .NET Sign in | Join | Help
in Search

DecoratedRuleArgs bug?

Last post 07-12-2008, 9:59 PM by RockfordLhotka. 7 replies.
Sort Posts: Previous Next
  •  04-22-2008, 6:34 AM 23000

    DecoratedRuleArgs bug?

    I think line 468 of DecoratedRuleArgs.cs should be

    sb.AppendFormat( "{0}={1}", System.Uri.EscapeDataString(item.Key), System.Uri.EscapeDataString(item.Value.ToString()) );

    because sometimes the value can be a regular expression string containing ? and & signs.
    Please correct me if I'm wrong.

    Regards,
    Rob

  •  04-22-2008, 8:00 AM 23013 in reply to 23000

    Re: DecoratedRuleArgs bug?

    I think you are right, that sounds like a potential issue. I'll add it to the list of things to work on. Thanks!


    Rocky
  •  06-26-2008, 7:35 AM 24346 in reply to 23013

    Re: DecoratedRuleArgs bug?

    Something else to consider: null values ?
  •  06-26-2008, 9:55 AM 24348 in reply to 24346

    RE: DecoratedRuleArgs bug?

    Good point – thanks!

     

    I’ve now changed the code to address these issues in 3.5.1.

     

    Rocky

     

     

    From: nelis [mailto:cslanet@lhotka.net]
    Sent: Thursday, June 26, 2008 7:36 AM
    To: rocky@lhotka.net
    Subject: Re: [CSLA .NET] DecoratedRuleArgs bug?

     

    Something else to consider: null values ?


    Rocky
  •  07-03-2008, 2:39 AM 24510 in reply to 24348

    Re: RE: DecoratedRuleArgs bug?

    Just downloaded 3.5.1

    DecoratedRuleArgs.ToString() still contains:

    sb.AppendFormat("{0}={1}", item.Key, item.Value.ToString());

    without checking item.Value for a null value

  •  07-03-2008, 9:20 AM 24519 in reply to 24510

    RE: RE: DecoratedRuleArgs bug?

    I must have made that change after I did the beta release. It is in svn

     

    http://www.lhotka.net/cslacvs/viewvc.cgi/trunk/cslacs/Csla/Validation/DecoratedRuleArgs.cs

     

    Rocky

     

     

    From: nelis [mailto:cslanet@lhotka.net]
    Sent: Thursday, July 03, 2008 7:08 AM
    To: rocky@lhotka.net
    Subject: Re: [CSLA .NET] RE: DecoratedRuleArgs bug?

     

    Just downloaded 3.5.1

    DecoratedRuleArgs.ToString() still contains:

    sb.AppendFormat("{0}={1}", item.Key, item.Value.ToString());

    without checking item.Value for a null value




    Rocky
  •  07-03-2008, 6:53 PM 24538 in reply to 24519

    Re: RE: RE: DecoratedRuleArgs bug?

    Does this apply to version 3.0.4 as well?


    Regards,
    William
  •  07-12-2008, 9:59 PM 24665 in reply to 24538

    RE: RE: RE: DecoratedRuleArgs bug?

    Yes, I’ve created a 3.0.5 in subversion (the branches\v3-0-x folder) that contains the fix, so when I do a 3.0.5 maintenance release it’ll be in there.

     

    Rocky

     

     

    From: William [mailto:cslanet@lhotka.net]
    Sent: Thursday, July 03, 2008 6:54 PM
    To: rocky@lhotka.net
    Subject: Re: [CSLA .NET] RE: RE: DecoratedRuleArgs bug?

     

    Does this apply to version 3.0.4 as well?




    Rocky
View as RSS news feed in XML

Please contact Magenic for your .NET consulting and CSLA .NET mentoring needs.
Please consider making a donation to help support the ongoing development of CSLA .NET.

Make donation through PayPal - it's fast, free and secure!
Why donate?
Powered by Community Server, by Telligent Systems