Slow Fetch() when business rules are implemented.

gajit posted on Wed, Mar 21 2012 2:00 PM

rated by 0 users

Hi gents,

Wonder if someone can put me back on the correct path...

It's taking an eon to perform a fetch on a single row because I have some properties that when changed, trigger other property changed events...

I'm pretty certain I'm doing it wrong... but I need a quick shove in the right direction...

I perform a fetch like so:

           Using data = New Csla.Data.SafeDataReader(dal.Fetch(_customerno))
                data.Read()

                Using BypassPropertyChecks

                    CustomerNo = data.GetString(data.GetOrdinal("CUSTOMERNO"))
                    MasterCustomerNo = data.GetString(data.GetOrdinal("MASTERCUSTOMERNO"))
                    Owner = data.GetString(data.GetOrdinal("OWNER"))
                    CompanyNo = data.GetString(data.GetOrdinal("COMPANYNO"))
                    Company = data.GetString(data.GetOrdinal("COMPANY"))
                    Address1 = data.GetString(data.GetOrdinal("ADDRESS1"))

What's killing the load time, is THIS type of property stub:

    Public Shared ReadOnly StateProperty As PropertyInfo(Of String) = RegisterProperty(Of String)(Function(c) c.State)
    <Display(Name:="State")> _
    Public Property State() As String
        Get
            Return GetProperty(StateProperty)
        End Get
        Set(value As String)
            SetProperty(StateProperty, value)
            PropertyHasChanged(CountryProperty)
            PropertyHasChanged(BranchProperty)
        End Set
    End Property

I basically have an (execute) command that is fired whenever the user changes the state, country or branch properties of my BO. So to make matters even worse, I have two propertyhaschanged() methods on the other two properties.

Should I be using a different method? Maybe BusinessRules.CheckRules?

As soon as a user changes any of the 3 values in the UI, I need to do the check and update the UI accordingly.

My validation rules look like:

            .AddRule(New CheckBranchIsValid() With {.PrimaryProperty = StateProperty})
            .AddRule(New CheckBranchIsValid() With {.PrimaryProperty = BranchProperty})
            .AddRule(New CheckBranchIsValid() With {.PrimaryProperty = CountryProperty})

and the execute looks like:

    Private Class CheckBranchIsValid
        Inherits Csla.Rules.BusinessRule
        Protected Overrides Sub Execute(context As Csla.Rules.RuleContext)

            Dim target = DirectCast(context.Target, CustomerEdit)

            If Not PrimaryProperty.Equals(BranchProperty) Then AffectedProperties.Add(BranchProperty)
            If Not PrimaryProperty.Equals(StateProperty) Then AffectedProperties.Add(StateProperty)
            If Not PrimaryProperty.Equals(CountryProperty) Then AffectedProperties.Add(CountryProperty)

            If Not CustomerEdit.BranchIsValid(target.Phone, target.Branch, target.State, target.Country) Then
                context.AddErrorResult("Branch, Country or State is invalid")
            End If

        End Sub
    End Class

I know I'm doing "something" wrong, just now sure what.

Any help would be appreciated.

Thanks,

Graham